-
Couldn't load subscription status.
- Fork 9.1k
HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part10. #7670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thank you @slfan1989 .
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, looks like there is a compilation problem in ITestS3AConfiguration.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1,LGTM @slfan1989
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1. Thanks @slfan1989 .
|
@Hexiaoqiao @cnauroth Appreciate the review! Merged this into trunk to keep things moving with the JUnit 5 upgrades across modules. cc: @zhtttylz |
…10. (apache#7670) * HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part10. Co-authored-by: Chris Nauroth <[email protected]> Co-authored-by: He Xiaoqiao <[email protected]> Co-authored-by: Hualong Zhang <[email protected]> Reviewed-by: Chris Nauroth <[email protected]> Reviewed-by: He Xiaoqiao <[email protected]> Reviewed-by: Hualong Zhang <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Description of PR
JIRA: HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part10.
How was this patch tested?
Junit Test & mvn clean test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?