HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part5. #7733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
slfan1989
reviewed
Jun 11, 2025
| assertEquals("The length of file should be the same to write size", fileLength, readLen); | ||
| Assert.assertArrayEquals(expected, result); | ||
| assertEquals(fileLength, readLen, "The length of file should be the same to write size"); | ||
| Assertions.assertArrayEquals(expected, result); |
There was a problem hiding this comment.
We should avoid importing via Assertions.*
There was a problem hiding this comment.
Thanks for the feedback! I'll update the code as soon as possible.
slfan1989
reviewed
Jun 11, 2025
| Integer.MAX_VALUE); | ||
| Assert.assertEquals("Blocks " + b + " has not been abandoned.", | ||
| orginalNumBlocks, blocks.locatedBlockCount() + 1); | ||
| Assertions.assertEquals(orginalNumBlocks, blocks.locatedBlockCount() + 1, "Blocks " + |
There was a problem hiding this comment.
We should avoid importing via Assertions.*
4c7fdc7 to
4495f11
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
78a06c2 to
fc58c36
Compare
|
💔 -1 overall
This message was automatically generated. |
fc58c36 to
fbf3c25
Compare
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Jun 13, 2025
| .assertTrue("File storage policy should be HOT", | ||
| status.getStoragePolicy() == HOT); | ||
| assertTrue( | ||
| status.getStoragePolicy() == HOT, "File storage policy should be HOT"); |
There was a problem hiding this comment.
Thanks for the feedback! I’ll update the code soon.
slfan1989
reviewed
Jun 13, 2025
| .assertTrue("File storage policy should be HOT", | ||
| status.getStoragePolicy() == HOT); | ||
| assertTrue( | ||
| status.getStoragePolicy() == HOT, "File storage policy should be HOT"); |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
approved these changes
Jun 14, 2025
|
Thanks @slfan1989 for reviewing and merging! |
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Jul 7, 2025
…pache#7733) * HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part5. Co-authored-by: Shilun Fan <[email protected]> Reviewed-by: Shilun Fan <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA:HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part5.
How was this patch tested?
Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?