HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part15. #7908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
cnauroth
requested changes
Aug 27, 2025
| bs.run(new String[]{"-force"}); | ||
| } catch (RuntimeException e) { | ||
| throw e.getCause(); | ||
| // 和原来一样，把包装的 cause 抛出来以匹配期望异常类型 |
There was a problem hiding this comment.
Can you please remove these comments or translate them to English?
There was a problem hiding this comment.
Thanks for the feedback—I’ll make the updates right away!
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Aug 29, 2025
| import org.junit.rules.TestName; | ||
| import org.junit.jupiter.api.AfterEach; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import static org.junit.jupiter.api.Assertions.*; |
slfan1989
reviewed
Aug 29, 2025
| jn.getJournalSyncerStatus(journalId)); | ||
| Assert.assertEquals(false, | ||
| jn.getJournal(journalId).getTriedJournalSyncerStartedwithnsId()); | ||
| Assertions.assertEquals(false, jn.getJournalSyncerStatus(journalId)); |
There was a problem hiding this comment.
The best way is to introduce it via the static method.
slfan1989
reviewed
Aug 29, 2025
| Assert.assertEquals(xattrs.size(), 2); | ||
| Assert.assertArrayEquals(value1, xattrs.get(name1)); | ||
| Assert.assertArrayEquals(value2, xattrs.get(name2)); | ||
| Assertions.assertEquals(xattrs.size(), 2); |
There was a problem hiding this comment.
The best way is to introduce it via the static method.
There was a problem hiding this comment.
Thank you for the review; I’ll roll the updates out shortly.
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
approved these changes
Aug 29, 2025
|
@zhtttylz Thanks for the contribution! LGTM. |
cnauroth
approved these changes
Aug 29, 2025
|
I committed this to trunk. @zhtttylz , thank you for the contribution. @slfan1989 , thank you for reviewing. |
@cnauroth Thank you very much for helping with the review! |
|
Thanks @cnauroth and @slfan1989 for reviewing and merging! |
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA:HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part15.
How was this patch tested?
Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?