Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HADOOP-19638. [Addendum] [JDK17] Set Up CI Support JDK17. #8030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2025
Merged

HADOOP-19638. [Addendum] [JDK17] Set Up CI Support JDK17. #8030

merged 3 commits into from
Oct 16, 2025

Conversation

@slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Oct 13, 2025 •
edited
Loading

Description of PR

JIRA: HADOOP-19638. [Addendum] [JDK17] Set Up CI Support JDK17.

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

zhtttylz
zhtttylz approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@zhtttylz zhtttylz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1,LGTM @slfan1989

@slfan1989 slfan1989 requested a review from Hexiaoqiao October 13, 2025 02:38
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 9m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 8m 52s Maven dependency ordering for branch
-1 ❌ mvninstall 15m 51s /branch-mvninstall-root.txt root in trunk failed.
+1 💚 mvnsite 0m 0s trunk passed
+1 💚 shadedclient 13m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 0m 0s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 0s the patch passed
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 shadedclient 13m 34s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 18s The patch does not generate ASF License warnings.
62m 58s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8030/2/artifact/out/Dockerfile
GITHUB PR #8030
Optional Tests dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs
uname Linux 8828e8951baa 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ac73fe1
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8030/2/testReport/
Max. process+thread count 573 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8030/2/console
versions git=2.25.1 maven=3.9.11 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 22m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 8m 52s Maven dependency ordering for branch
+1 💚 mvninstall 37m 36s trunk passed
+1 💚 mvnsite 0m 0s trunk passed
+1 💚 shadedclient 32m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
+1 💚 mvninstall 0m 0s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 0s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shadedclient 32m 35s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
136m 57s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8030/1/artifact/out/Dockerfile
GITHUB PR #8030
Optional Tests dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs
uname Linux d7c4c36f06f4 5.15.0-144-generic #157-Ubuntu SMP Mon Jun 16 07:33:10 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ac73fe1
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8030/1/testReport/
Max. process+thread count 529 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8030/1/console
versions git=2.25.1 maven=3.9.11 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 9m 38s Maven dependency ordering for branch
+1 💚 mvninstall 15m 43s trunk passed
+1 💚 mvnsite 0m 0s trunk passed
+1 💚 shadedclient 13m 38s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 0m 0s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 0s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shadedclient 13m 20s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 21s The patch does not generate ASF License warnings.
54m 52s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8030/3/artifact/out/Dockerfile
GITHUB PR #8030
Optional Tests dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs
uname Linux 0bd5ffd3e04f 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2c677ac
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8030/3/testReport/
Max. process+thread count 729 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8030/3/console
versions git=2.25.1 maven=3.9.11 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor Author

@cnauroth @szetszwo Could you please help review this PR? Thank you very much! We have confirmed that the current Hadoop version can be successfully compiled with both JDK 17 and JDK 21. I plan to add support for these two JDK versions.

@slfan1989
Copy link
Contributor Author

@steveloughran Could you please review this PR? Thank you very much!

@slfan1989
Copy link
Contributor Author

@Hexiaoqiao Could you please review this PR? Thank you very much!

szetszwo
szetszwo reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slfan1989 , thanks for working on this! Just have a question inlined.

dev-support/jenkins.sh
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-17-openjdk-amd64")
# test with Java 17 & Java 21
YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-17-openjdk-amd64")
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-21-openjdk-amd64")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need two jdk dirs?

--multijdkdirs=/usr/lib/jvm/java-21-openjdk-amd64,/usr/lib/jvm/java-17-openjdk-amd64

https://yetus.apache.org/documentation/0.15.1/precommit/usage-intro/#multijdk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for helping with the review! Since I’m not yet very familiar with Yetus, the current configuration was created by referring to and simulating the original JDK 8 and JDK 11 configurations.

# test with Java 8 and 11
YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8-openjdk-amd64")
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-11-openjdk-amd64")
YETUS_ARGS+=("--multijdktests=compile")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Let's keep using it then.

szetszwo
szetszwo approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

dev-support/jenkins.sh
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-17-openjdk-amd64")
# test with Java 17 & Java 21
YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-17-openjdk-amd64")
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-21-openjdk-amd64")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Let's keep using it then.

Hexiaoqiao
Hexiaoqiao approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@Hexiaoqiao Hexiaoqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 from my side.

@slfan1989 slfan1989 merged commit 77d72b6 into apache:trunk Oct 16, 2025
1 of 3 checks passed
@slfan1989
Copy link
Contributor Author

@szetszwo @Hexiaoqiao @zhtttylz Thank you very much for reviewing the code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szetszwo szetszwo szetszwo approved these changes

@Hexiaoqiao Hexiaoqiao Hexiaoqiao approved these changes

@cnauroth cnauroth Awaiting requested review from cnauroth

@steveloughran steveloughran Awaiting requested review from steveloughran

+1 more reviewer

@zhtttylz zhtttylz zhtttylz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infra trunk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slfan1989 @hadoop-yetus @szetszwo @Hexiaoqiao @zhtttylz