Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HDFS-16408. Negative LeaseRecheckIntervalMs will let LeaseMonitor loop forever and print huge amount of log #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

HDFS-16408. Negative LeaseRecheckIntervalMs will let LeaseMonitor loop forever and print huge amount of log #3856

merged 1 commit into from
Jan 5, 2022

Conversation

@liever18
Copy link
Contributor

@liever18 liever18 commented Jan 5, 2022

Description of PR

Add Preconditions.checkArgument() to ensure the leaseRecheckIntervalMs cannot get set to a value less than or equal to zero.

It avoids negative intervals that cause LeaseMonitor to be in a constant state of fast printing exception logs

JIRA: HDFS-16408

How was this patch tested?

when the configuration item 'dfs.namenode.lease-recheck-interval-ms' is accidentally set to a negative number, origin code will print warning log again and again immediately. This problem can be eliminated after using this patch.

sodonnel
sodonnel approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@sodonnel sodonnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending good CI run.

@hadoop-yetus
Copy link

hadoop-yetus commented Jan 5, 2022

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 30m 54s trunk passed
+1 💚 compile 1m 25s trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 compile 1m 17s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 1m 1s trunk passed
+1 💚 mvnsite 1m 26s trunk passed
+1 💚 javadoc 1m 3s trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 31s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 3m 11s trunk passed
+1 💚 shadedclient 22m 25s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 16s the patch passed
+1 💚 compile 1m 19s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javac 1m 19s the patch passed
+1 💚 compile 1m 13s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 1m 13s the patch passed
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 checkstyle 0m 52s the patch passed
+1 💚 mvnsite 1m 15s the patch passed
+1 💚 javadoc 0m 51s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 26s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 3m 14s the patch passed
+1 💚 shadedclient 22m 11s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 226m 40s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
335m 14s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3856/1/artifact/out/Dockerfile
GITHUB PR #3856
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux f900077faa71 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 4cdd250
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3856/1/testReport/
Max. process+thread count 3226 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3856/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@liever18
Copy link
Contributor Author

liever18 commented Jan 5, 2022

@sodonnel
In my opinion, there is no need to add additional unit tests to verify the patch.
What is your suggestion?

@sodonnel
Copy link
Contributor

sodonnel commented Jan 5, 2022

This is fine with no unit tests. I will commit this later as it looks good now.

@liever18
Copy link
Contributor Author

liever18 commented Jan 5, 2022

This is fine with no unit tests. I will commit this later as it looks good now.

thanks for your review. @sodonnel

@sodonnel sodonnel merged commit e1d0aa9 into apache:trunk Jan 5, 2022
asfgit pushed a commit that referenced this pull request Jan 5, 2022
@liever18
HDFS-16408. Ensure LeaseRecheckIntervalMs is greater than zero (#3856)
3a82899 
(cherry picked from commit e1d0aa9)
asfgit pushed a commit that referenced this pull request Jan 5, 2022
@liever18
HDFS-16408. Ensure LeaseRecheckIntervalMs is greater than zero (#3856)
1e1e4a2 
(cherry picked from commit e1d0aa9)
sunchao pushed a commit that referenced this pull request Jan 5, 2022
@liever18 @sunchao
HDFS-16408. Ensure LeaseRecheckIntervalMs is greater than zero (#3856)
d167ef4 
(cherry picked from commit e1d0aa9)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@liever18
HDFS-16408. Ensure LeaseRecheckIntervalMs is greater than zero (apach…
d9d5538 
…e#3856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sodonnel sodonnel sodonnel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liever18 @hadoop-yetus @sodonnel