refactor(bindings/c)!: extract the writer closing logic from opendal_writer_free #6128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Your Name <[email protected]>
|
There are still 2 pending items:
|
Signed-off-by: Your Name <[email protected]>
acb76e9 to
a613a65
Compare
|
Also cc @yuchanns, it looks like we need to collaborate on this. Would you like to push your changes for the Go bindings to this branch directly? |
|
Sure. Leave it to me. |
Properly implement Writer.Close() to ensure resources are freed and underlying writer is closed correctly. This change adds proper error handling and resource cleanup. Signed-off-by: Hanchin Hsieh <[email protected]>
|
Now it's fixed. BTW: This is not a breaking change as to Go binding. |
Xuanwo
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6125.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?