Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sijie
Copy link
Member

@sijie sijie commented Mar 5, 2018

This change is based on #1329

701df16 is the commit for review in this PR.

  • rename pulsar-client-tools-shaded to pulsar-client-admin-shaded-for-functions, because this module is used by functions only to avoid protobuf conflicts
  • move protobuf3 references to Utils, so it won't be referenced out side of pulsar-functions
  • integrate function cli into pulsar-admin cli
    701df16

@sijie sijie self-assigned this Mar 5, 2018
@sijie sijie requested review from merlimat and rdhabalia March 5, 2018 09:12
@sijie
Copy link
Member Author

sijie commented Mar 5, 2018

/cc @srkukarni @jerrypeng

sijie added 2 commits March 5, 2018 11:11
- rename `pulsar-client-tools-shaded` to `pulsar-client-admin-shaded-for-functions`, because this module is used by functions only to avoid protobuf conflicts
- move protobuf3 references to Utils, so it won't be referenced out side of pulsar-functions
- integrate function cli into pulsar-admin cli
@sijie sijie force-pushed the integrate_functions_cli branch from 701df16 to c5a7779 Compare March 5, 2018 21:27
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sijie
Copy link
Member Author

sijie commented Mar 5, 2018

retest this please

@merlimat merlimat merged commit 6230ab4 into apache:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants