If there is an error in reading from ZK, DiscoveryService should fail when reading partitions metadata #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when reading partitions metadata
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
The `compile` scope in dependency plugin means : compile, provided, and system dependencies
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
This PR is the first step to port Kafka Streams' [integration tests](https://github.com/apache/kafka/tree/2.0/streams/src/test/java/org/apache/kafka/streams/integration) to KoP. There're two main differences from the original tests in Kafka: 1. Kafka's tests use a lot of util methods from different modules, so this PR adds a `TestUtils.java` to collect all necessary util methods. 2. This PR abstracts a base class for reused variables and methods. Based on the framework, this PR ports the tests for `GlobalKTable`. It should be noted that in `shouldRestoreGlobalInMemoryKTableOnRestart` we sleep for 1 second after `startStreams()` because it may take a few milliseconds to wait streams started in KoP. Finally, the old test for word count example is deleted since it will be redundant after tests are ported.
dlg99
added a commit
to dlg99/pulsar
that referenced
this pull request
May 23, 2024
dlg99
added a commit
to dlg99/pulsar
that referenced
this pull request
May 28, 2024
(cherry picked from commit f1323c6)
dlg99
added a commit
to dlg99/pulsar
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit f1323c6)
dlg99
added a commit
to dlg99/pulsar
that referenced
this pull request
Sep 16, 2024
(cherry picked from commit f1323c6)
dlg99
added a commit
to dlg99/pulsar
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit f1323c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The lookup for the partitioned topic metadata should not silently succeed when the discovery service is failing at getting the info from ZK.
Modifications
Fixed the ZK cache to throw exception instead of
Optional.empty()on any error different from a ZKNoNodeException.