Close HTTP client connection upon server error or per HTTP spec #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides 500, other errors indicate that the server is having problems, so close the connection to avoid sending requests to the same bad server. DefaultKeepAliveStrategy will look at the request and response headers for other reasons to close, such as "Connection: close" headers.
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
merlimat
approved these changes
Mar 2, 2017
rdhabalia
pushed a commit
that referenced
this pull request
Mar 10, 2017
Besides 500, other errors indicate that the server is having problems, so close the connection to avoid sending requests to the same bad server. DefaultKeepAliveStrategy will look at the request and response headers for other reasons to close, such as "Connection: close" headers.
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
apache#273) * Create ProcessBuilder at during start() so that start() can be called multiple times from Spawner * Fix unittest
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
…pache#274) Fixes apache#273 When KoP handles metadata requests, it only checks the config allowAutoTopicCreation but not the same field in the metadata request. Then it causes that AdminClient#describeTopics returns a success result even if the topics don't exist and topics will be created automatically. So this PR adds the check for metadata request's allowAutoTopicCreation field and the test for AdminClient#describeTopics.
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
May 23, 2024
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
May 28, 2024
(cherry picked from commit 6d2e494)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit 6d2e494)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Sep 16, 2024
(cherry picked from commit 6d2e494)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit 6d2e494)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Besides 500, other errors indicate that the server is having problems,
so close the connection to avoid sending requests to the same bad
server. We also want to respect "Connection: close" headers which
were handled by the default client config.
Modifications
Extend DefaultKeepAliveStrategy and return false for any 5xx HTTP response.
Result
5xx response -> connection closed