Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the authentication components to support Laravel 12.x while introducing adjustments to Passport configurations, routes, and database migrations. Key changes include renaming secret fields to plainSecret, updating data types and assertions in WebClient, and modifying Passport route registrations and related tests.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/Containers/AppSection/Authentication/Values/Clients/WebClient.php | Adjusts parameter types and renames secret to plainSecret for consistency with Passport updates. |
| app/Containers/AppSection/Authentication/Values/Clients/Client.php | Updates the interface method to use plainSecret. |
| app/Containers/AppSection/Authentication/UI/API/Routes/Passport.v1.private.php | Updates and adds several route registrations to support new Passport controllers and JSON API routes. |
| Various test files | Updates tests to reflect changes in method names, route registrations, and token revocation behavior. |
| Migration files | Revises schema definitions (e.g. switching from int to uuid/bpchar) to support Laravel 12.x standards. |
| Data/Factories files | Makes corresponding updates in token and client factories to reflect the refactoring changes. |
| Config/passport.php | Removes configuration sections no longer needed in the new Passport setup. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 13.x #781 +/- ##
============================================
+ Coverage 78.16% 84.06% +5.89%
- Complexity 354 360 +6
============================================
Files 180 181 +1
Lines 1177 1192 +15
============================================
+ Hits 920 1002 +82
+ Misses 257 190 -67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dan-wolf-at
pushed a commit
to dan-wolf-at/apiato
that referenced
this pull request
Jun 5, 2025
[API-1290] laravel 12.x support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change