Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 20, 2022. It is now read-only.

Conversation

@d-gs
Copy link
Member

@d-gs d-gs commented Nov 3, 2021

Type of request

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring
  • Documentation or documentation changes

Related Issue(s)

Closes #37

Concept

Description of the change

  • Add GemException fatal state
  • Add GemExceptionManager to the workbench context to be used for creatable classes and retrieve on the UI plug-in (also include the messages on the properties for i18n)
  • Implement an abstract handler using the exception manager to inform user if the handler fails (and close the application if it is fatal)
  • Use the new APIs where required

Checklist:

  • All the commits are signed.
  • My code follows the code style of this project.
  • I agree with die CLA.
  • I have read the CONTRIBUTING docs.
  • I have added/updated necessary documentation (if appropriate).

@d-gs d-gs requested a review from davu-all November 3, 2021 10:18
davu-all
davu-all previously approved these changes Nov 4, 2021
@d-gs d-gs merged commit 7426cb2 into main Nov 4, 2021
@d-gs d-gs deleted the gem/main/d-gs/#37 branch November 4, 2021 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Refresh does not close the application for wrong configuration

3 participants