Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 20, 2022. It is now read-only.

Conversation

@d-gs
Copy link
Member

@d-gs d-gs commented Dec 13, 2021

Type of request

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring
  • Documentation or documentation changes

Related Issue(s)

Closes #34
Closes #35

Concept

Description of the change

  • Cleanup and simplify Obsolete Environment classes
  • Fix obsolete environments not removed from the dialog after deletion (refresh cache)
  • Add Select/Unselect all checkbox on dialog for better UX.

Checklist:

  • All the commits are signed.
  • My code follows the code style of this project.
  • I agree with die CLA.
  • I have read the CONTRIBUTING docs.
  • I have added/updated necessary documentation (if appropriate).

@d-gs d-gs requested a review from davu-all December 13, 2021 08:54
Copy link
Contributor

@davu-all davu-all left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many changes. In general look ok 👍

@d-gs d-gs merged commit 2deaf07 into main Dec 14, 2021
@d-gs d-gs deleted the gem/main/d-gs/cleanupObsoleteEnvironmentClasses branch December 14, 2021 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

'Clean / Obsolete Environments' dialog shows removed environments after first run 'Select All' feature on 'Clean / Obsolete Environment' dialog

3 participants