This repository was archived by the owner on Dec 20, 2022. It is now read-only.
Use tab-folder for cli-like dialog #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanFranzWeiser
previously approved these changes
Dec 14, 2021
Comment on lines
171
to
172
| // TODO: if only one command, do we really need the tab-folder? | ||
| final CTabFolder tabFolder = new CTabFolder(parent, SWT.TOP); |
Member
There was a problem hiding this comment.
I think, keeping a single tab-folder is better than changing the layout and interface (consistency). Furthermore, the recognition value is higher for the user.
Member
Author
There was a problem hiding this comment.
Leftover for some considerations I have when I implemented. Next commit will remove this and other TODOs that are not any longer relevant.
davu-all
approved these changes
Dec 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of request
Related Issue(s)
Closes #36
Concept
Description of the change
Checklist: