Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 20, 2022. It is now read-only.

Conversation

@d-gs
Copy link
Member

@d-gs d-gs commented Sep 8, 2021

Currently the not ACCEPTED libs that are on the project does not make the build fail (found with org.zeroturnaround.zt-exec wrongly identified with the sources instead with the binary where the license information is not found).

  • The first commit demonstrate how the failure would look like on the checks.
  • The second commit adds the detection for the lib that is UNKNOWN
  • The third commit updates the NOTICE.txt to be sure that it is using the correct jar name

@d-gs d-gs requested a review from davu-all September 8, 2021 09:58
@d-gs d-gs requested a review from holzerma September 8, 2021 10:03
Copy link
Contributor

@davu-all davu-all left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-gs d-gs merged commit 0d27c67 into main Sep 8, 2021
@d-gs d-gs deleted the gem/main/d-gs/fixLicenseScoutCheck branch September 8, 2021 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants