Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 20, 2022. It is now read-only.

Conversation

@d-gs
Copy link
Member

@d-gs d-gs commented Oct 15, 2021

Type of request

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring
  • Documentation or documentation changes

Related Issue(s)

Preparations for preference framework to be implemented with #21

Concept

Description of the change

  • Repackage preference-related classes
  • Extract configuration (json/hocon) read/write logic to its own class (HoconFilesManager)
  • Change default preferences for application to HOCON format (user_prefs.conf)
  • Implement persist logic for preferences file (still not used by the framework)

Checklist:

  • All the commits are signed.
  • My code follows the code style of this project.
  • I agree with die CLA.
  • I have read the CONTRIBUTING docs.
  • I have added/updated necessary documentation (if appropriate).

@d-gs d-gs requested a review from davu-all October 15, 2021 10:10
@d-gs d-gs force-pushed the gem/main/d-gs/refactorForPrefFramework branch from a33131b to 9813564 Compare October 15, 2021 10:12
davu-all
davu-all previously approved these changes Oct 15, 2021
@d-gs d-gs merged commit 81dd71e into main Oct 15, 2021
@d-gs d-gs deleted the gem/main/d-gs/refactorForPrefFramework branch October 15, 2021 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants