This repository was archived by the owner on Aug 14, 2020. It is now read-only.
avoid O(N) and fix defer reader close #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Murdaca <[email protected]>
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| defer res.Body.Close() |
There was a problem hiding this comment.
I just noticed that the original res doesn't get closed if this if block gets dropped into. Would you mind adding a res.Body.Close() around like 507 while you're here?
There was a problem hiding this comment.
there's a problem however, response body closing is an issue in all of this routine in case of any errors during the function, I'll add a defer
|
LGTM |
|
@dgonyeo reworked the second commit so that if there's an error and the |
| } | ||
|
|
||
| defer func() { | ||
| if err != nil { |
There was a problem hiding this comment.
Just "and" those to save indentation?
|
One nit but LGTM afterwards. |
Signed-off-by: Antonio Murdaca <[email protected]>
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.