This repository was archived by the owner on Aug 14, 2020. It is now read-only.
Avoid panicing on scratch images #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker allows creating empty images (e.g. with FROM scratch followed by a no-op like MAINTAINER or LABEL). Without this patch, docker2aci will panic when it encounters an image of this sort. These images are more-or-less useless. They're also difficult to work with. As an example, `docker save` bails on them with an `unimplemented` error. In line with that behavior, I think bailing in docker2aci makes sense too rather than dealing with more robust error handling or creating an empty ACI.
|
|
cgonyeo
approved these changes
Jun 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker allows creating empty images (e.g. with FROM scratch followed by
a no-op like MAINTAINER or LABEL).
Without this patch, docker2aci will panic when it encounters an image of
this sort.
These images are more-or-less useless. They're also difficult to work
with. As an example,
docker savebails on them with anunimplementederror.
In line with that behavior, I think bailing in docker2aci makes sense
too rather than dealing with more robust error handling or creating an
empty ACI.