lib/internal: fix tar header format #260
Conversation
|
The Format field is exposed since Go 1.10, should the CI bump its Go version? |
|
Thanks for the PR. While we can definitely bump the CI environment, it sounds like this would introduce an hard requirement on go >= 1.10 for all library consumers. Is there no other way to achieve the same? |
|
As long as it uses |
|
@iaguis any feedback? I would typically wait till 1.9 goes out of support (i.e. August 2018), but at the same time this seems worth fixing in a shorter term. |
|
Reading the reference issue on coreos/bugs#2402, it seems docker2aci on CoreOS 1688.5.3 not affected by this. However I don't use CoreOS, not sure what version the docker2aci it uses. If this is a regression in docker2aci, then we can fix it without bumping Go dependency to 1.10. |
|
As suggested in the issue of Go, I changed the PR to copy Header struct. |
After manipulating the Name and Linkname, the orignal Header format may be invalid. Starting from Go 1.10, the Header format is stored in the Header struct. >For forward compatibility, users that retrieve a Header from Reader.Next, >mutate it in some ways, and then pass it back to Writer.WriteHeader should >do so by creating a new Header and copying the fields that they are >interested in preserving. The copied fields are taken from all the fields presented in Go 1.6. Ref: golang/go#24821 Closes: appc#259 Signed-off-by: Shengjing Zhu <[email protected]>
fix tar header format after manipulating the Name and Linkname.
Fixes: #259