This repository was archived by the owner on May 21, 2022. It is now read-only.
Fix returning HTTP/1.1 connections back to the pool with inflight requests #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uests If we receive a timeout while waiting for a response then it is possible to return the connection back to the pool while we are still waitiing for the response. For HTTP/1.1 this will trigger the pipelining logic within Mint. However, Mint does not let us call stream_request_body while pipelining requests. Also, pipelining is not necessarily desirable since the client has to wait for their previous timed out response to be received before they are able to receive the response for their new request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we receive a timeout while waiting for a response then it is possible to
return the connection back to the pool while we are still waitiing for the
response. For HTTP/1.1 this will trigger the pipelining logic within Mint.
However, Mint does not let us call stream_request_body while pipelining
requests. Also, pipelining is not necessarily desirable since the client
has to wait for their previous timed out response to be received before
they are able to receive the response for their new request.