Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FEATURE] Patch command #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 14, 2023
Merged

[FEATURE] Patch command #736

merged 7 commits into from
Feb 14, 2023

Conversation

@marcinc
Copy link
Contributor

@marcinc marcinc commented Feb 9, 2023 •
edited
Loading

This PR adds new patch subcommand that is responsible for patching images for specified services in previously generated K8s manifests. This might come handy when iterating on the application externally e.g. from CI, in particular with image building and publishing managed by external processes.

NOTE:

  • By default all changes are inline i.e. original manifests for specified services will be overridden in place.
    • It's possible to provide output directory for patched manifests via --output-dir (Caveat: only patched manifests will be stored in the output dir!)
  • Source directory is traversed and all matching manifests will be affected. In order to scope patching to a particular set of manifests make sure that the path is provided specifically to that one directory.
Examples:

### Patch images for specified services
$ tako patch --dir /path/to/k8s/manifests --image myservice=myimage:v1.0.1 --image myservice2=myimage2:v2.0.2

### Patch images for specified services and store patched manifests in a different directory
$ tako patch --dir /path/to/k8s/manifests --image myservice=myimage:v1.0.1 --image myservice2=myimage2:v2.0.2 --output-dir /path/to/patched/manifests

Usage:
  tako patch [flags]

Flags:
  -d, --dir string          Path to the kubernetes manifests that require patching. (default ".")
  -i, --image strings       Image to be patched in deployment files for a given service name. Format: <service>=<image>.
  -o, --output-dir string   Path to directory where patched manifests should be stored.
                            ⌙ Output directory structure will reflect that of the source directory tree.
                            ⌙ Note that only manifests that were patched will be stored in the output directory!
                            ⌙ Manifests will be overridden in-place if output directory is not specified.
  -h, --help                help for patch

@marcinc marcinc marked this pull request as ready for review February 10, 2023 18:19
@marcinc
fixup! Adds new patch subcommand responsible for patching images for …
87de7fe 
…specified services. All changes are done inline.
@marcinc marcinc mentioned this pull request Feb 10, 2023
Merged
KashifSaadat
KashifSaadat previously approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@KashifSaadat KashifSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcinc marcinc requested a review from KashifSaadat February 14, 2023 09:53
@marcinc marcinc merged commit 3755afd into master Feb 14, 2023
@marcinc marcinc deleted the patch-command branch February 14, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KashifSaadat KashifSaadat KashifSaadat approved these changes

@gambol99 gambol99 Awaiting requested review from gambol99

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcinc @KashifSaadat