Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Revert "Added handling of database resources after migration"#10406

Merged
abnegate merged 1 commit into1.8.xfrom
revert-10400-dat-664
Aug 29, 2025
Merged

Revert "Added handling of database resources after migration"#10406
abnegate merged 1 commit into1.8.xfrom
revert-10400-dat-664

Conversation

@abnegate
Copy link
Member

Reverts #10400

@linear
Copy link

linear bot commented Aug 29, 2025

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 29, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This change removes StatsUsage usage from the codebase in two areas. In Appwrite\Event\StatsUsage, the public reset() method is deleted. In Appwrite\Platform\Workers\Migrations, all StatsUsage dependencies and metrics collection logic are removed: imports, constructor/parameters, method signatures, aggregated resource handling, per-resource stats emission, the processMigrationResourceStats helper, and the $source member. Migrations’ action() and processMigration() now omit StatsUsage and operate without stats aggregation, with the Transfer callback simplified to a no-argument closure.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 PHPStan (2.1.17)

Note: Using configuration file /phpstan.neon.
Invalid entry in excludePaths:
Path "/app/sdks" is neither a directory, nor a file path, nor a fnmatch pattern.

If the excluded path can sometimes exist, append (?)
to its config entry to mark it as optional. Example:

parameters:
excludePaths:
analyseAndScan:
- app/sdks (?)


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e005389 and eab03af.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • src/Appwrite/Event/StatsUsage.php (0 hunks)
  • src/Appwrite/Platform/Workers/Migrations.php (4 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-10400-dat-664

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@abnegate abnegate merged commit c7bbb6a into 1.8.x Aug 29, 2025
10 of 11 checks passed
@abnegate abnegate deleted the revert-10400-dat-664 branch August 29, 2025 10:45
@github-actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link

✨ Benchmark results

  • Requests per second: 1,277
  • Requests with 200 status code: 229,833
  • P99 latency: 0.151984104

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,277 1,038
200 229,833 186,969
P99 0.151984104 0.188215135

@ArnabChatterjee20k ArnabChatterjee20k mentioned this pull request Oct 17, 2025
2 tasks
@ArnabChatterjee20k ArnabChatterjee20k restored the revert-10400-dat-664 branch October 17, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant