-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: bump utopia dns #10761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump utopia dns #10761
Conversation
|
Warning Rate limit exceeded@loks0n has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 27 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR upgrades utopia-php/dns in composer.json from 0.3.* to 1.1.* and migrates DNS handling to the v1 API. The DNS validator (src/Appwrite/Network/Validator/DNS.php) is refactored to use Utopia DNS Message/Question/Client APIs, switches record type usage to Utopia\DNS\Message\Record::TYPE_* ints, changes the constructor signature and server property, removes getLogs(), tightens input validation, rewrites query/CAA handling with new private helpers, and updates getDescription(). Call sites (proxy rules, Certificates worker) and unit tests are updated to use Record::TYPE_* constants. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
1acf531 to
67076ec
Compare
67076ec to
bacfcdf
Compare
bacfcdf to
b42cc11
Compare
✨ Benchmark results
⚡ Benchmark Comparison
|
No description provided.