Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@loks0n
Copy link
Member

@loks0n loks0n commented Nov 4, 2025

No description provided.

@loks0n loks0n changed the base branch from main to 1.8.x November 4, 2025 10:40
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

Warning

Rate limit exceeded

@loks0n has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between bacfcdf and b42cc11.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (9)
  • composer.json (1 hunks)
  • src/Appwrite/Network/Validator/DNS.php (1 hunks)
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/API/Create.php (2 hunks)
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/Function/Create.php (2 hunks)
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/Redirect/Create.php (2 hunks)
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/Site/Create.php (2 hunks)
  • src/Appwrite/Platform/Modules/Proxy/Http/Rules/Verification/Update.php (3 hunks)
  • src/Appwrite/Platform/Workers/Certificates.php (3 hunks)
  • tests/unit/Network/Validators/DNSTest.php (5 hunks)
📝 Walkthrough

Walkthrough

This PR upgrades utopia-php/dns in composer.json from 0.3.* to 1.1.* and migrates DNS handling to the v1 API. The DNS validator (src/Appwrite/Network/Validator/DNS.php) is refactored to use Utopia DNS Message/Question/Client APIs, switches record type usage to Utopia\DNS\Message\Record::TYPE_* ints, changes the constructor signature and server property, removes getLogs(), tightens input validation, rewrites query/CAA handling with new private helpers, and updates getDescription(). Call sites (proxy rules, Certificates worker) and unit tests are updated to use Record::TYPE_* constants.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

  • Heterogeneous but focused changes: dependency bump plus API migration in one validator class and consistent constant replacements across multiple files.
  • Files needing extra attention:
    • src/Appwrite/Network/Validator/DNS.php — new control flow, exception handling, CAA parsing, constructor signature and server initialization.
    • Call sites in src/Appwrite/Platform/Modules/Proxy/** and src/Appwrite/Platform/Workers/Certificates.php — ensure Record::TYPE_* int usage and no remaining string-constant assumptions.
    • tests/unit/Network/Validators/DNSTest.php — verify tests align with new behavior (CAA parent validation, logs removal).

Possibly related PRs

Suggested reviewers

  • Meldiron
  • vermakhushboo

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether any description content relates to the changeset. Add a description explaining the purpose of the utopia-php/dns upgrade, migration details, and any breaking changes or compatibility notes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: bump utopia dns' directly summarizes the main change—upgrading the utopia-php/dns dependency from 0.3.* to 1.1.*, which involves cascading updates throughout the codebase.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@10761

commit: 1acf531

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.44-r2 CVE-2025-5244 HIGH
binutils 2.44-r2 CVE-2025-5245 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
pcre2 10.43-r1 CVE-2025-58050 CRITICAL
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH
stdlib 1.22.10 CVE-2025-47912 HIGH
stdlib 1.22.10 CVE-2025-58183 HIGH
stdlib 1.22.10 CVE-2025-58186 HIGH
stdlib 1.22.10 CVE-2025-58187 HIGH
stdlib 1.22.10 CVE-2025-58188 HIGH
stdlib 1.22.10 CVE-2025-61724 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@loks0n loks0n force-pushed the feat-bump-utopia-dns branch from 1acf531 to 67076ec Compare November 4, 2025 10:43
@loks0n loks0n force-pushed the feat-bump-utopia-dns branch from 67076ec to bacfcdf Compare November 4, 2025 10:53
@loks0n loks0n force-pushed the feat-bump-utopia-dns branch from bacfcdf to b42cc11 Compare November 4, 2025 10:56
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

✨ Benchmark results

  • Requests per second: 1,160
  • Requests with 200 status code: 208,757
  • P99 latency: 0.167403049

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,160 1,200
200 208,757 216,017
P99 0.167403049 0.174353511

@loks0n loks0n merged commit bf5aa7b into 1.8.x Nov 4, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants