Add ID import to storage quick start examples #2417
Conversation
WalkthroughThe docs file src/routes/docs/products/storage/quick-start/+page.markdoc was updated: the client-web create-file example now imports ID from "appwrite" and uses it for fileId; the server-nodejs example uses the module alias Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (3)
src/routes/docs/products/storage/quick-start/+page.markdoc (3)
49-53: Standardize Cloud endpoint to include region.Other examples use https://.cloud.appwrite.io/v1. Align Node sample for consistency and fewer 301/geo issues.
Apply this diff:
- .setEndpoint('https://cloud.appwrite.io/v1') + .setEndpoint('https://<REGION>.cloud.appwrite.io/v1')
113-116: Android: import Context (used below).Apply this diff:
import io.appwrite.Client import io.appwrite.services.Storage import io.appwrite.ID +import android.content.Context
226-228: Flutter download: add missing semicolon after writeAsBytesSync.Small syntax fix.
Apply this diff:
- file.writeAsBytesSync(bytes) + file.writeAsBytesSync(bytes);Additionally, add
import 'dart:io';at the top of this snippet soFileresolves.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/routes/docs/products/storage/quick-start/+page.markdoc(6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: tests
🔇 Additional comments (4)
src/routes/docs/products/storage/quick-start/+page.markdoc (4)
23-23: Good call adding ID import to web example.Makes the ID.unique() usage explicit and copy‑pasteable.
94-110: Swift sample looks correct.API usage and async/await are consistent.
159-180: HTTP multipart example: LGTM.Headers, operations/map, and file part look correct.
303-306: React Native download: object-params confirmed — no change required.Appwrite React Native docs use an object signature for Storage.getFileDownload (bucketId, fileId, optional token); the snippet in src/routes/docs/products/storage/quick-start/+page.markdoc lines 303–306 already matches.
Summary by CodeRabbit