Get safe path #91
Open
Get safe path #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for a lot of if-else... Just add a backslash if required, then append the character.
This was referenced Apr 29, 2022
This fixes... incrond[1714]: cannot exec process: Resource temporarily unavailable ... with bad file name due to messing escaping.
avcbvamorec
added a commit
to avcbvamorec/incron
that referenced
this pull request
Mar 17, 2023
|
The correct way is to only escape the single-quote, and then put the path variables '$@' '$#' in them in commands. Other characters need not be escaped, as they will not be treated as special within single-quoted strings. See #101 |
|
The way you have done it, when the path variables are in single quotes, everything inside will be treated literally so the literal name of a file containing something like The lesson here is always use single quotes for any input in shell, and always only escape the single quote itself within it. This memory rule prevents problems with escaping special characters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.