src/cmd/src/table.rs (1)

71-72: Heads-up: MGET cross-slot behavior.

Current storage routing uses only the first key’s instance (see storage_impl comment). That’s fine for single-instance, but in a sharded/clustered setup MGET should fan out and preserve key order. Consider adding a TODO here linking to a tracking issue for multi-instance fan‑out.

src/cmd/src/mget.rs (1)

70-95: Minor: preallocate response capacity.

Tiny perf tweak: reserve capacity before mapping results.

-            Ok(values) => {
-                // Convert Option<String> to RespData
-                let resp_array: Vec<RespData> = values
+            Ok(values) => {
+                // Convert Option<String> to RespData
+                let mut resp_array: Vec<RespData> = Vec::with_capacity(values.len());
+                resp_array.extend(
+                    values
                     .into_iter()
-                    .map(|opt_val| match opt_val {
-                        Some(val) => RespData::BulkString(Some(val.into_bytes().into())),
-                        None => RespData::BulkString(None),
-                    })
-                    .collect();
+                    .map(|opt_val| match opt_val {
+                        Some(val) => RespData::BulkString(Some(val.into_bytes().into())),
+                        None => RespData::BulkString(None),
+                    })
+                );
 
                 client.set_reply(RespData::Array(Some(resp_array)));

src/cmd/src/append.rs (2)

68-78: Forward all RedisErr messages (consistency with other commands)

Currently only WRONGTYPE is forwarded; others are wrapped. Mirror setex/psetex/getset behavior.

-            Err(e) => match e {
-                storage::error::Error::RedisErr { ref message, .. }
-                    if message.starts_with("WRONGTYPE") =>
-                {
-                    // RedisErr already contains the formatted message
-                    client.set_reply(RespData::Error(message.clone().into()));
-                }
-                _ => {
-                    client.set_reply(RespData::Error(format!("ERR {e}").into()));
-                }
-            },
+            Err(e) => match e {
+                storage::error::Error::RedisErr { ref message, .. } => {
+                    client.set_reply(RespData::Error(message.clone().into()));
+                }
+                _ => client.set_reply(RespData::Error(format!("ERR {e}").into())),
+            },

---

52-55: Minor: avoid repeated argv cloning

Cache argv once per function to reduce small allocations.

Also applies to: 59-63

src/cmd/src/getset.rs (1)

72-81: Ensure GETSET clears TTL (Redis semantics)

GETSET should overwrite the key and clear any existing expire. Please confirm storage.getset removes TTL; if not, adjust.

Reference: “The timeout will only be cleared by commands that delete or overwrite the contents of the key, including … GETSET …”. (redis.io)

src/cmd/src/setrange.rs (1)

81-86: Optional: cap resulting length before storage call

If storage enforces i32::MAX result length, consider pre-checking offset + value.len() to fail fast and return a user-friendly ERR.

src/storage/tests/redis_string_test.rs (3)

688-739: Add WRONGTYPE coverage for APPEND

This test only exercises string keys. Please add a case where a non-string key (e.g., created via hset) is passed to append and assert WRONGTYPE.

---

2158-2240: Add GETSET TTL-clearing test

Per Redis, GETSET overwrites and clears any existing expire. Consider a test: SETEX key 1 "v"; then GETSET key "w"; sleep 2s; assert key still exists ("w").

Reference: “The timeout will only be cleared by commands that delete or overwrite the contents of the key, including … GETSET …”. (redis.io)

Also applies to: 2242-2287

---

741-786: Perf nit: avoid UTF-8 .chars() on large ASCII payloads

Use bytes to validate content and length to reduce overhead.

-assert_eq!(final_value.len(), 10 * 1024 * 1024);
-assert!(final_value.chars().all(|c| c == 'x'));
+assert_eq!(final_value.as_bytes().len(), 10 * 1024 * 1024);
+assert!(final_value.as_bytes().iter().all(|&b| b == b'x'));

Also applies to: 773-779

src/storage/src/storage_impl.rs (1)

63-109: Per-key delegations LGTM; consider a small DRY helper

Straightforward, consistent slot routing. Optionally extract a helper to reduce repetition, e.g., compute instance_id once and invoke a closure.

src/storage/src/redis_strings.rs (3)

486-524: Clippy: replace redundant pattern match with is_err() in MGET

Use is_err() to satisfy lint and simplify logic.

-                    // Check type - if not string type, return None (like Redis does)
-                    if let Err(_) = self.check_type(val.as_slice(), DataType::String) {
+                    // Check type - if not string type, return None (like Redis does)
+                    if self.check_type(val.as_slice(), DataType::String).is_err() {
                         results.push(None);
                         continue;
                     }

Also applies to: 501-505

---

124-127: Minor cleanup: prefer unwrap_or_default() for Vecs

Replace unwrap_or_else(Vec::new) with unwrap_or_default for brevity.

-    .context(RocksSnafu)?
-    .unwrap_or_else(Vec::new);
+    .context(RocksSnafu)?
+    .unwrap_or_default();

Also applies to: 179-182, 285-288, 380-383, 1064-1067

---

413-419: Optional: unify error text prefix

Elsewhere you use “ERR …”; here it’s “string exceeds maximum allowed size”. Consider “ERR string exceeds maximum allowed size” for consistency.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro