Codecov Report

Merging #137 into master will increase coverage by 0.17%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   23.92%   24.09%   +0.17%     
==========================================
  Files          59       59              
  Lines        1049     1054       +5     
  Branches      168      167       -1     
==========================================
+ Hits          251      254       +3     
- Misses        798      800       +2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9cfe5f...6456de9. Read the comment docs.

My only concern is with the backward compatibility issue we will introduce moving GraphQLWrapper to #gql. I think is the right decision but we should clearly state that the next version has breaking changes.

I was wondering if you saw code using the inherited GraphQLWrapper methods? I was considering it to be an internal API.

In terms of breaking changes, I was more thinking about the constructor params of the connectors. But I don’t see a reason to instantiate ConnectorTheGraph manually since it’s embedded, so chances are that people won’t have to make any change here.

In any case, I 100% agree that we should document any breaking change (or any other change 😄) in the public API 👍

No totally, you are right. I got confused by the inheritance. Developers are using the GraphQLWrapper directly and not from the OrganizationConnector so should no be backward compatibility issues other than what you mention about constructor params.