Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@onbjerg
Copy link
Contributor

@onbjerg onbjerg commented Jul 23, 2020

This commit adds a metric that signifies the number of times an app has been installed.

I couldn't find a nice way to have a single "global" entity that could serve as a container for global metrics such as an overall organization count, so I opted to not implement that and resort to summing the orgCount properties of each organization factory in Apiary. If you have another idea I'd be glad to hear it 👍

Closes #139

This commit adds a metric that signifies the number of times
an app has been installed.
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   24.88%   24.88%           
=======================================
  Files          59       59           
  Lines        1069     1069           
  Branches      160      160           
=======================================
  Hits          266      266           
  Misses        803      803           
Flag Coverage Δ
#unittests 24.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9212af7...493cefc. Read the comment docs.

@bpierre bpierre requested a review from 0xGabi July 23, 2020 13:21
Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @onbjerg

Maybe we can include a new Metric entity that keeps track of this general information?

@0xGabi 0xGabi merged commit 20c662e into aragon:master Jul 29, 2020
@onbjerg onbjerg deleted the app-count branch July 30, 2020 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Organization and app install metrics

2 participants