Support RF64 file format via libsndfile #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the RF64 file format as an output option alongside the existing WAV format support, both using libsndfile. RF64 is an extended version of the WAV format that can handle larger file sizes.
- Added RF64 as a new writer type with corresponding string conversion and factory function
- Refactored the WAV writer implementation to be reusable for both WAV and RF64 formats
- Updated documentation and version number to reflect the new capability
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/writer.h | Adds WRITER_TYPE_RF64 enum value |
| src/writer.c | Adds string conversion for RF64 type |
| src/writer-wav.h | Adds writer_rf64_new function declaration |
| src/writer-wav.c | Refactors WAV writer to support both WAV and RF64 formats |
| src/main.c | Integrates RF64 support into main application logic |
| README.md | Updates documentation to mention RF64 support |
| CMakeLists.txt | Bumps version from 1.4.0 to 1.5.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.