cmd/ocprometheus: Set timestamps #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96009ae to
4e26344
Compare
Now that Prometheus and OpenMetrics support timestamps, forward them from gNMI to the exporter.
4e26344 to
d73cc27
Compare
|
Okay, this might not have the desired effect; apparently Prometheus only stores the value with the given timestamp and assumes that the value is no longer valid if the timestamp is not updated during the next scrape. Perhaps the discussion of timestamps should simply be removed from the README (or replaced with an explanation why ocprometheus does not consume them, as above)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Prometheus and OpenMetrics support timestamps, forward
them from gNMI to the exporter.