Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@arl
Copy link
Owner

@arl arl commented Sep 3, 2022

Use runtime/metrics as source of metrics (rather than runtime.Memstats which is less performant and less complete).

Rework UI

arl added 30 commits March 12, 2022 16:41
This is a first step towards a dynamic definition of the plots we
show. For this we add a Plot javascript class, which we call to
create/update plotly plots.
This time we're preparing to tackle the stats part, or -how to
extract specific stats from the raw data and assign them to
specific plots-.
This is necessary since the application is going to need to
access (in stats.js) to the plots configuration before the plots
are created.
At this point, the only non-dynamic (as in non-externally configurable)
point is the 'datapath' field. That's for now a function in the plot
definition object where we map our raw stats object to a data point.

Eventually, this won't be necessary since this will all be defined in
Go.
This will simplify the mini websocket-based protocol we'll have,
breaking down a single do-it-all message into 2, one for the desired
plots configuration - the 'init' message- and the 'data' message,
that will just contain the data.
Upwards, as in: closer to Go, where all data processing will eventually
be performed.
For now we're still plotting runtime.MemStats though
@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #75 (a072a6b) into main (583356d) will decrease coverage by 8.26%.
The diff coverage is 74.19%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   97.91%   89.65%   -8.27%     
==========================================
  Files           3        3              
  Lines          48       87      +39     
==========================================
+ Hits           47       78      +31     
- Misses          1        6       +5     
- Partials        0        3       +3     
Impacted Files Coverage Δ
statsviz.go 68.18% <57.14%> (-21.82%) ⬇️
handlers.go 94.28% <88.23%> (-5.72%) ⬇️
register.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants