-
-
Notifications
You must be signed in to change notification settings - Fork 124
Use runtime metrics / new UI #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first step towards a dynamic definition of the plots we show. For this we add a Plot javascript class, which we call to create/update plotly plots.
This time we're preparing to tackle the stats part, or -how to extract specific stats from the raw data and assign them to specific plots-.
This is necessary since the application is going to need to access (in stats.js) to the plots configuration before the plots are created.
At this point, the only non-dynamic (as in non-externally configurable) point is the 'datapath' field. That's for now a function in the plot definition object where we map our raw stats object to a data point. Eventually, this won't be necessary since this will all be defined in Go.
This will simplify the mini websocket-based protocol we'll have, breaking down a single do-it-all message into 2, one for the desired plots configuration - the 'init' message- and the 'data' message, that will just contain the data.
Upwards, as in: closer to Go, where all data processing will eventually be performed.
For now we're still plotting runtime.MemStats though
This reverts commit 9d6be37.
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 97.91% 89.65% -8.27%
==========================================
Files 3 3
Lines 48 87 +39
==========================================
+ Hits 47 78 +31
- Misses 1 6 +5
- Partials 0 3 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Sep 5, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use runtime/metrics as source of metrics (rather than runtime.Memstats which is less performant and less complete).
Rework UI