Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@helgrima
Copy link
Contributor

#4 this breaks current example song, but maybe that can be fixed later.

@helgrima
Copy link
Contributor Author

I will provide new 4klang.h and 4klang.inc files.

@helgrima
Copy link
Contributor Author

Example song with 4klang 3.11. With 4klang 3.11 export contains 4klang.h and 4klang.inc instead of 4klang.obj. Included yasm.exe compiles 4klang.inc to 4klang.obj.

@armak
Copy link
Owner

armak commented Nov 22, 2022

In principle building everything in one go is a good idea, but I'm worried about maintaining the versioning properly for 4klang. In many cases the music is made by a separate party, and they might be using a different version of the synthesizer, producing .inc files that potentially lead to incomprehensible build errors, or worse, catastrophic runtime failures (been there).

For that reason I think it's ultimately preferable to try to always build the 4klang binary file separately, using only the sources found in its distribution package to avoid the cases above. This is how I feel about the topic for now anyway, but maybe I'll come around, so I'll heave this PR pending and open still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants