add new board radxa-cm4-io #8604
Conversation
WalkthroughAdds a new board configuration file config/boards/radxa-cm4-io.csc for an RK3576-based Radxa CM4-IO board. Declares board metadata (BOARD_NAME, BOARDFAMILY, BOOTCONFIG, KERNEL_TARGET, FULL_DESKTOP, BOOT_LOGO, BOOT_FDT_FILE, BOOT_SCENARIO, IMAGE_PARTITION_TABLE), extension flags (enable_extension "radxa-aic8800", AIC8800_TYPE "usb", BOARD_MAINTAINER ""), and a post_family_tweaks__radxa-cm4-io_naming_audios() function that emits an info alert, ensures "$SDCARD/etc/udev/rules.d/" exists, writes three udev rules to "$SDCARD/etc/udev/rules.d/90-naming-audios.rules" (one overwrite and two appends) to name HDMI0, DP0, and ES8388 audio devices, and returns 0. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
config/boards/radxa-cm4-io.csc (3)
1-1: Polish the one-line board summary.Follow the Armbian single-line spec style; fix typos (“NvME”, “GBe”, duplicated “SoC”) for clarity.
Apply:
-# Rockchip RK3576 SoC octa core 8-64GB SoC 2*GBe eMMC USB3 NvME WIFI +# Rockchip RK3576 octa-core; 8–64GB RAM; dual GbE; eMMC; USB 3; NVMe; Wi‑Fi
13-13: Set BOARD_MAINTAINER to enable CODEOWNERS generation.Empty value skips maintainers in .github/generate_CODEOWNERS.sh. Add at least the author or team.
-BOARD_MAINTAINER="" +BOARD_MAINTAINER="amazingfate" # add others as needed, space-separated
16-16: Tweak alert copy.“Audios” → “audio devices”.
- display_alert "$BOARD" "Renaming radxa-cm4-io audios" "info" + display_alert "$BOARD" "Renaming Radxa CM4-IO audio devices" "info"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
config/boards/radxa-cm4-io.csc(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-06-16T03:24:00.458Z
Learning: In Armbian board configuration files (.csc), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features.
📚 Learning: 2025-06-16T03:24:00.458Z
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-06-16T03:24:00.458Z
Learning: In Armbian board configuration files (.csc), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features.
Applied to files:
config/boards/radxa-cm4-io.csc
🧬 Code graph analysis (1)
config/boards/radxa-cm4-io.csc (2)
extensions/radxa-aic8800.sh (2)
post_install_kernel_debs__install_aic8800_dkms_package(11-63)extension_finish_config__install_kernel_headers_for_aic8800_dkms(1-9).github/generate_CODEOWNERS.sh (1)
generate_for_board(18-68)
🔇 Additional comments (2)
config/boards/radxa-cm4-io.csc (2)
19-21: Verify udev match keys on the built image
Run on your target device:udevadm info --export-db | grep -E 'platform-(dp0|hdmi0|es8388)-sound'Ensure these exact ENV{ID_PATH} entries exist or adjust the udev rules accordingly.
15-15: Ignore hyphen-name warning: the function in config/boards/radxa-cm4-io.csc uses only underscores, so there is no bash parse error.Likely an incorrect or invalid review comment.
cc57250 to
b26327e
Compare
|
✅ This PR has been reviewed and approved — all set for merge! |
b26327e to
cf9aa95
Compare
|
✅ This PR has been reviewed and approved — all set for merge! |
Description
This depends on armbian/linux-rockchip#397
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
./compile.sh BOARD=radxa-cm4-io BRANCH=vendor KERNEL_CONFIGURE=no DEB_COMPRESS=xz KERNEL_BTF=yes KERNEL_GIT=shallow BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED= DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base RELEASE=trixieChecklist:
Please delete options that are not relevant.