Thanks to visit codestin.com
Credit goes to github.com

Skip to content

rockchip64: update tm16xx driver from kernel mailing list #8679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2025
Merged

rockchip64: update tm16xx driver from kernel mailing list #8679

merged 2 commits into from
Sep 28, 2025

Conversation

@paolosabatino
Copy link
Contributor

@paolosabatino paolosabatino commented Sep 27, 2025

Description

tm16xx auxiliary display led driver has been submitted to kernel mailing lists for upstreaming process. It received several modifications from kernel maintainers; this PR updates the patch within rockchip64 edge archive with the most up to date driver.

Mostly for tvboxes which have a front panel led display, but any board can benefit since display chips communicate via I2C/SPI bus.

Also "promote" timer led trigger from module to built-in.

How Has This Been Tested?

  • Rockchip64 edge kernel compiled and tested successfully on live system

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@paolosabatino paolosabatino requested a review from a team September 27, 2025 12:41
@github-actions github-actions bot added the 11 Milestone: Fourth quarter release label Sep 27, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 27, 2025 •
edited
Loading

Walkthrough

This change updates kernel configuration for rockchip64-edge by splitting TM16XX support into separate I2C and SPI options (adding CONFIG_TM16XX_I2C and CONFIG_TM16XX_SPI, removing CONFIG_TM16XX) and switches LED trigger timer (CONFIG_LEDS_TRIGGER_TIMER) from module to built-in.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

Ready to merge, Hardware, Patches, size/small

Suggested reviewers

  • igorpecovnik
  • amazingfate
  • leggewie
  • pyavitz

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly states that the tm16xx driver for the rockchip64 platform is being updated based on patches from the kernel mailing list, succinctly summarizing the primary change without extraneous detail. It highlights the affected platform and the source of the driver updates, making it clear and specific. This wording allows teammates to understand the main intent at a glance.
Description Check ✅ Passed The pull request description directly outlines the purpose of the update to the tm16xx auxiliary display LED driver, notes the promotion of the timer LED trigger, and provides testing validation on the Rockchip64 edge kernel. It is clearly related to the changeset and conveys relevant information about the implementation and verification. This level of detail is sufficient for understanding the scope of the changes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 83ccbbf and 1ba3fc9.

⛔ Files ignored due to path filters (3)
  • patch/kernel/archive/rockchip64-6.16/general-driver-tm16xx-led-driver.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip64-6.16/overlay/rockchip-rk3318-box-led-conf2.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip64-6.16/overlay/rockchip-rk3318-box-led-conf5.dtso is excluded by !patch/**
📒 Files selected for processing (1)
  • config/kernel/linux-rockchip64-edge.config (2 hunks)
🔇 Additional comments (2)
config/kernel/linux-rockchip64-edge.config (2)

2001-2002: Config split matches the upstream driver refresh.

Selecting both the I²C and SPI transport modules keeps feature parity with the new tm16xx layout while preserving the previous modular footprint. Looks good.

2682-2682: Bundling the timer trigger resolves probe-ordering gaps.

Making the timer trigger built-in guarantees it is present when tm16xx comes up, eliminating optional soft-dependencies. Nice catch.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Sep 27, 2025
@coderabbitai coderabbitai bot requested a review from leggewie September 27, 2025 12:42
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Sep 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2025

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Sep 28, 2025
@igorpecovnik igorpecovnik merged commit 343df94 into armbian:main Sep 28, 2025
1 check passed
@paolosabatino paolosabatino deleted the update-tm16xx branch September 28, 2025 08:00
@hqnicolas hqnicolas mentioned this pull request Oct 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

@ColorfulRhino ColorfulRhino Awaiting requested review from ColorfulRhino ColorfulRhino is a code owner

@HeyMeco HeyMeco Awaiting requested review from HeyMeco HeyMeco is a code owner

@JohnTheCoolingFan JohnTheCoolingFan Awaiting requested review from JohnTheCoolingFan JohnTheCoolingFan is a code owner

@SuperKali SuperKali Awaiting requested review from SuperKali SuperKali is a code owner

@TRSx80 TRSx80 Awaiting requested review from TRSx80 TRSx80 is a code owner

@TheSnowfield TheSnowfield Awaiting requested review from TheSnowfield TheSnowfield is a code owner

@Tonymac32 Tonymac32 Awaiting requested review from Tonymac32 Tonymac32 is a code owner

@ahoneybun ahoneybun Awaiting requested review from ahoneybun ahoneybun is a code owner

@amazingfate amazingfate Awaiting requested review from amazingfate amazingfate is a code owner

@brentr brentr Awaiting requested review from brentr brentr is a code owner

@catalinii catalinii Awaiting requested review from catalinii catalinii is a code owner

@chainsx chainsx Awaiting requested review from chainsx chainsx is a code owner

@clee clee Awaiting requested review from clee clee is a code owner

@efectn efectn Awaiting requested review from efectn efectn is a code owner

@joekhoobyar joekhoobyar Awaiting requested review from joekhoobyar joekhoobyar is a code owner

@krachlatte krachlatte Awaiting requested review from krachlatte krachlatte is a code owner

@lanefu lanefu Awaiting requested review from lanefu lanefu is a code owner

@prahal prahal Awaiting requested review from prahal prahal is a code owner

@pyavitz pyavitz Awaiting requested review from pyavitz pyavitz is a code owner

@rpardini rpardini Awaiting requested review from rpardini rpardini is a code owner

@schwar3kat schwar3kat Awaiting requested review from schwar3kat schwar3kat is a code owner

@leggewie leggewie Awaiting requested review from leggewie

Assignees

No one assigned

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paolosabatino @igorpecovnik