Thanks to visit codestin.com
Credit goes to github.com

Skip to content

compress-checksum: introduce COMPRESS_OUTPUTIMAGE=zst #9101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EvilOlaf merged 1 commit into from
Dec 19, 2025
Merged

compress-checksum: introduce COMPRESS_OUTPUTIMAGE=zst #9101

EvilOlaf merged 1 commit into from
Dec 19, 2025
+5 −0

Conversation

@rpardini
Copy link
Member

@rpardini rpardini commented Dec 18, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Added support for zstd compression as an alternative image compression method, with configurable compression levels.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025 •
edited
Loading

Walkthrough

A new zstd-based compression branch is added to the image compression function. When COMPRESS_OUTPUTIMAGE contains "zst", the function displays a status message, compresses the image using zstdmt with configurable compression level, removes the original file, and sets the compression type suffix to ".zst".

Changes

Cohort / File(s) Summary
Zstd compression support
lib/functions/image/compress-checksum.sh		 Adds elif branch for zstd compression in output_images_compress_and_checksum function with configurable ZSTD_COMPRESSION_LEVEL, file cleanup, and proper compression type assignment

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify zstdmt command syntax and compression level defaults
  • Confirm file removal logic correctly targets original uncompressed file
  • Validate compression_type variable assignment matches intended suffix
  • Ensure elif branching preserves existing xz compression path behavior

Poem

🐰 Zstd arrives with speed and grace,
A compress path joins the race,
With levels tuned, just set and go,
File shrinks fast, no longer slow,
Our images now have choices new! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: introducing zstd compression support via the COMPRESS_OUTPUTIMAGE=zst option.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 02 Milestone: First quarter release size/small PR with less then 50 lines labels Dec 18, 2025
@rpardini rpardini marked this pull request as ready for review December 18, 2025 22:55
@rpardini rpardini requested a review from a team as a code owner December 18, 2025 22:55
@github-actions github-actions bot added Needs review Seeking for review Framework Framework components labels Dec 18, 2025
coderabbitai[bot]
coderabbitai bot reviewed Dec 18, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between de044ed and 5e9a126.

📒 Files selected for processing (1)
  • lib/functions/image/compress-checksum.sh (1 hunks)

@EvilOlaf EvilOlaf mentioned this pull request Dec 19, 2025
Merged
EvilOlaf
EvilOlaf approved these changes Dec 19, 2025
View reviewed changes
Copy link
Member

@EvilOlaf EvilOlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Pleasre review the changes to documentation if I picked that up correctly.

@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Dec 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Dec 19, 2025
@rpardini
Copy link
Member Author

rpardini commented Dec 19, 2025

Thanks for the docs @EvilOlaf

@EvilOlaf
Copy link
Member

EvilOlaf commented Dec 19, 2025

Welcome

@EvilOlaf EvilOlaf merged commit d4f7046 into armbian:main Dec 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@EvilOlaf EvilOlaf EvilOlaf approved these changes

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees

No one assigned

Labels

02 Milestone: First quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rpardini @EvilOlaf @igorpecovnik