Execute JS challenge logic before Symfony startup #2054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b378e12 to
757819b
Compare
048d51c to
40e91d1
Compare
anvit
reviewed
Jun 25, 2025
Contributor
anvit
left a comment
There was a problem hiding this comment.
I just have a question about a small change, everything else looks good!
| \n | ||
| # Development-specific configuration | ||
| expose_php = on | ||
| opcache.validate_timestamps = on |
Contributor
There was a problem hiding this comment.
Is this change related to this fix? I couldn't figure out why this was removed from the docker config.
Member
Author
There was a problem hiding this comment.
Good catch! Accidental leftover from trying to squeeze performance out of PHP. I will restore this line.
Member
Author
There was a problem hiding this comment.
Fixed in most recent commit
anvit
approved these changes
Jun 25, 2025
Extract the JS challenge from the Symfony filterchain, action, and template into minimal PHP entry points. These new files run before Symfony’s autoloader is invoked. Scripts are CSP‐compliant and use localStorage for state. Bypassing the full Symfony framework for these endpoints significantly improves request performance. If the `config/appChallenge.yml` file is missing, AtoM's JS Challenge feature will be deactivated.
eb96ded to
cfa587c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the JS challenge from the Symfony filterchain, action, and template into
minimal PHP entry points. These new files run before Symfony’s autoloader is
invoked. Scripts are CSP‐compliant and use localStorage for state. Bypassing
the full framework bootstrap for bot and headless‐browser endpoints eliminates
unnecessary overhead and significantly improves request performance.