Restore new related material formatting and fix 500 error when linking containers #2085
Conversation
|
I'd just like to add that this also addresses the following buggy behaviour currently being experienced with this field:
|
|
@anvit The bugs reported in this forum thread are related to this issue: https://groups.google.com/g/ica-atom-users/c/mxILsWx_BxU The entities reporting missing properties are all non-information object relations linked to descriptions in various ways. Johan noticed that the 500 errors can still be reproduced with non-B5 themes. I only addressed the B5 theme here, but will add a commit that covers the others. |
|
067b1ff tested and confirmed to fix the 500 errors Johan was able to reproduce with non-B5 themes. |
@mInnes-archives ah I see! No wonder I wasn't able to reproduce this, I hadn't been testing with those. Thanks so much for the fixes! Will take a look tomorrow. I see that you've pushed the fixes for the BS2 version as well, but just wanted to give you a heads up that 2.10 will be removing BS2 support entirely, so while those changes might be helpful for anyone who wants to cherry-pick them from the qa branch, they would not actually ship in the new release and will be removed when we merge #2066 |
PR reverts all previous fix attempts to the related material descriptions field back to what was introduced in #1900 and properly addresses the 500 error caused when storage containers were added to descriptions with related material links.
Basically since containers are also relations, the relations here should have just included information objects. #1900 didn't do that, so it crashed (#1987). The existing type check just needed to be moved earlier. The previous fix attempts using
property_existsandmethod_existswere always returningfalse, meaning the error was being removed by way of never allowing the new elements added in #1900 to be included in the link. All intended functionality is now restored (as far as I can tell).