Resend Request Controller Overridden Begin Seq No #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d request, from an overridden beginSeqNum, gapfilling prior messages
artio-core/src/main/java/uk/co/real_logic/artio/engine/logger/GapFiller.java
Fixed
Show fixed
Hide fixed
wojciech-adaptive
approved these changes
Jun 18, 2025
|
|
||
| testSystem.await("Failed to receive messages", () -> | ||
| { | ||
| final long totalReplayedMessages = acceptingOtfAcceptor.messages().size(); |
There was a problem hiding this comment.
s/Replayed/Received/
| final List<FixMessage> fixMessageList = acceptingOtfAcceptor.messages(); | ||
| final FixMessage gapFill = fixMessageList.get(0); | ||
| assertEquals(SEQUENCE_RESET_MESSAGE, gapFill.messageType()); | ||
| assertEquals(1, gapFill.messageSequenceNumber()); |
There was a problem hiding this comment.
Shall we add an assertion on GapFillFlag and NewSeqNo values?
artio-core/src/main/java/uk/co/real_logic/artio/engine/logger/GapFiller.java
Fixed
Show fixed
Hide fixed
marc-adaptive
added a commit
that referenced
this pull request
Jun 23, 2025
Introduce ResendRequestResponse option to allow responding to a resend request, from an overridden beginSeqNum, gapfilling prior messages (cherry picked from commit b221dee)
writeoncereadmany
pushed a commit
to TransFICC/artio
that referenced
this pull request
Oct 13, 2025
Introduce ResendRequestResponse option to allow responding to a resend request, from an overridden beginSeqNum, gapfilling prior messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users more control over responding to resend requests by allowing user to programatically decide from what sequence number they would like to replay, gapfilling prior messages.