chore: do not prefetch RouterLink on new architecture#12832
Merged
MounirDhahri merged 1 commit intomainfrom Oct 10, 2025
Merged
chore: do not prefetch RouterLink on new architecture#12832MounirDhahri merged 1 commit intomainfrom
MounirDhahri merged 1 commit intomainfrom
Conversation
Contributor
brainbicycle
approved these changes
Oct 10, 2025
Contributor
brainbicycle
left a comment
There was a problem hiding this comment.
this looks reasonable to me, and the check is great! can we bring back to mobile practice to get opinions? I think ideal state is to have prefetching possible in new architecture if possible but we have some time
Member
Author
|
@brainbicycle yesss that's the plan - I am planning on discussing it with @olerichter00 further and Chriss when he's back |
Contributor
great! to be clear i think fine to merge gated behind the flag in the meantime! |
Member
Author
|
@brainbicycle I updated the PR description to include the context from our DMs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-2389
Description
This PR disables prefetching
RouterLinkcomponents on the new architecture. This change is required in order to make the home view usable.Rationale:
Currently, our
Sentinelcomponent creates an interval onRouterLinkto measure components position. We do that so:The latter was fine in the old architecture and didn't lead to a performance degradation, however in the new architecture, it plummeted the performance and had a big impact on the CPU load.
Hopefully, we will find a replacement to keep a similar experience and find an alternative to our
Sentinel. I will look into doing this on a different thread later to see if we can offset the loadPR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.