Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: 'Contact Gallery' dialog should hide the questions message when there are no inquiry questions available. #12857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oxaudo merged 1 commit into from
Oct 17, 2025
Merged

chore: 'Contact Gallery' dialog should hide the questions message when there are no inquiry questions available. #12857

oxaudo merged 1 commit into from
Oct 17, 2025

Conversation

@oxaudo
Copy link
Member

@oxaudo oxaudo commented Oct 16, 2025 •
edited
Loading

This PR resolves [https://artsyproduct.atlassian.net/browse/EMI-2886]

Description

For now just hiding this questions prompt when no inquiry questions are available for a given artwork.

Platform Before After
iOS

PR Checklist

  • I have tested my changes on the following platforms:
    • [] Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • hide questions prompt on inquiry modal when no questions are present

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@oxaudo oxaudo requested a review from MrSltun October 16, 2025 21:04
@oxaudo oxaudo self-assigned this Oct 16, 2025
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Oct 16, 2025

This PR contains the following changes:

  • Cross-platform user-facing changes (Drop questions prompt on inquiry modal when no questions are present - oxaudo)

Generated by 🚫 dangerJS against a0bd146

@oxaudo oxaudo requested a review from starsirius October 16, 2025 21:14
@oxaudo oxaudo merged commit 576bf97 into main Oct 17, 2025
7 checks passed
@oxaudo oxaudo deleted the oxaudo/quest branch October 17, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrSltun MrSltun MrSltun approved these changes

@starsirius starsirius Awaiting requested review from starsirius

Assignees

@oxaudo oxaudo

Labels

Jira Synced

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oxaudo @ArtsyOpenSource @MrSltun