Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: sticky nav on artist page experiment branch#16430

Merged
dzucconi merged 22 commits intomainfrom
review-app-sticky-nav
Jan 5, 2026
Merged

feat: sticky nav on artist page experiment branch#16430
dzucconi merged 22 commits intomainfrom
review-app-sticky-nav

Conversation

@dzucconi
Copy link
Member

@dzucconi dzucconi commented Dec 2, 2025

Screen.Recording.2025-12-19.at.9.26.48.AM.mov

cc @artsy/diamond-devs

@dzucconi dzucconi requested a review from a team December 2, 2025 13:57
@dzucconi dzucconi self-assigned this Dec 2, 2025
@relativeci
Copy link

relativeci bot commented Dec 3, 2025

#5773 Bundle Size — 9.52MiB (-0.09%).

6cd62af(current) vs d8bc7f8 main#5768(baseline)

Warning

Bundle contains 34 duplicate packages – View duplicate packages

Bundle metrics  Change 7 changes Regression 2 regressions
                 Current
#5773
     Baseline
#5768
Regression  Initial JS 3.71MiB(+0.14%) 3.7MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 75.11% 40.75%
Change  Chunks 99(-2.94%) 102
Change  Assets 102(-2.86%) 105
Change  Modules 5963(+0.3%) 5945
Regression  Duplicate Modules 600(+2.04%) 588
Change  Duplicate Code 4.01%(-9.68%) 4.44%
No change  Packages 297 297
No change  Duplicate Packages 33 33
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#5773
     Baseline
#5768
Improvement  JS 9.38MiB (-0.09%) 9.39MiB
Improvement  Other 143.71KiB (-0.4%) 144.28KiB

Bundle analysis reportBranch review-app-sticky-navProject dashboard


Generated by RelativeCIDocumentationReport issue

@dzucconi dzucconi force-pushed the review-app-sticky-nav branch 4 times, most recently from 22c4562 to 706e251 Compare December 11, 2025 13:06
@dzucconi dzucconi force-pushed the review-app-sticky-nav branch 6 times, most recently from 1bc77e6 to 5f81483 Compare December 18, 2025 14:59
@dzucconi dzucconi force-pushed the review-app-sticky-nav branch from 5f81483 to d10dc50 Compare December 19, 2025 14:25
@dzucconi dzucconi marked this pull request as ready for review December 19, 2025 14:25
@dzucconi dzucconi force-pushed the review-app-sticky-nav branch from d10dc50 to dde1b65 Compare December 19, 2025 14:34
@dzucconi dzucconi changed the title feat: sticky nav review app feat: sticky nav on artist page experiment branch Dec 19, 2025
@dzucconi dzucconi force-pushed the review-app-sticky-nav branch from dde1b65 to d3af771 Compare January 5, 2026 12:41
@dzucconi dzucconi enabled auto-merge January 5, 2026 12:42
@dzucconi dzucconi force-pushed the review-app-sticky-nav branch from d3af771 to 6cd62af Compare January 5, 2026 13:16
@dzucconi dzucconi disabled auto-merge January 5, 2026 13:35
@dzucconi dzucconi merged commit f63a9c4 into main Jan 5, 2026
15 checks passed
@dzucconi dzucconi deleted the review-app-sticky-nav branch January 5, 2026 13:35
@artsy-peril artsy-peril bot mentioned this pull request Jan 5, 2026

return (
<Dropdown
dropdownZIndex={Z.dropdown}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @dzucconi
I noticed that after this change the quick filter is displaying on top of the menu dropdown

Image

I'm also working on this ticket, not sure if it's related to your PR, please let me know if it is, otherwise I'll keep looking into it. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dariakoko unrelated. But that one is easily fixed in Palette. I made this ticket today: https://artsyproduct.atlassian.net/browse/DIAM-253

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, possibly related. Either way the fix is the same: we need to add an underlay in Palette to catch the mouse.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll close the Onyx ticket then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants