Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(DIAM-97): Add field for link to author website #16492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lilyfromseattle merged 3 commits into from
Dec 18, 2025
Merged

feat(DIAM-97): Add field for link to author website #16492

lilyfromseattle merged 3 commits into from
Dec 18, 2025
+37 −6

Conversation

@lilyfromseattle
Copy link
Contributor

@lilyfromseattle lilyfromseattle commented Dec 15, 2025 •
edited
Loading

The type of this PR is: Feat

@artsy/diamond-devs

This PR solves DIAM-97

NOTE: I added WIP because I am still waiting on Ryan to confirm what icon we want here

Description

- We need to add a new field for Website to the new Author Settings page
- We need to add it to the edit form in [Writer](https://writer.artsy.net/settings/authors) so that we can add this field 
- This new field should display on the public author page below the existing social icons.

Acceptance Criteria

- A new input field for “Personal Website” is added to the Author Settings in Writer 
- On the author’s page, the personal website appears below the current social links.
- The link is shown next to one of the icons like the social ones (select from [Palette Icons](https://palette.artsy.net/atoms/icons/))
- Confirm final icon choice with Ryan (options: HomeIcon, PaymentIcon, PublicationIcon, SoloIcon).
- Website link opens in a new tab when clicked
Before After
Screenshot 2025-12-15 at 3 03 02 PM Screenshot 2025-12-16 at 1 03 01 PM

dzucconi
dzucconi reviewed Dec 15, 2025
View reviewed changes
Copy link
Member

@dzucconi dzucconi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I still the the normal LinkIcon is a bit more standard.

Example, Github:

@lilyfromseattle lilyfromseattle changed the title feat(DIAM-97): Add field for link to author website WIP: feat(DIAM-97): Add field for link to author website Dec 15, 2025
@lilyfromseattle lilyfromseattle self-assigned this Dec 15, 2025
@lilyfromseattle
Copy link
Contributor Author

lilyfromseattle commented Dec 15, 2025

Looks good but I still the the normal LinkIcon is a bit more standard.

Example, Github:

Yes good point, I forgot to put WIP on this but the ticket said to have Ryan select the icon and I'm still waiting on a resposne from him, so I just picked one to use as a placeholder

@relativeci
Copy link

relativeci bot commented Dec 16, 2025 •
edited
Loading

#5642 Bundle Size — 9.51MiB (+0.02%).

a4760bf(current) vs 38926d7 main#5633(baseline)

Warning

Bundle contains 34 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression
                 Current
#5642		      Baseline
#5633
Regression  Initial JS 3.7MiB(~+0.01%) 3.7MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 38.24% 37.48%
No change  Chunks 102 102
No change  Assets 105 105
Change  Modules 5937(+0.02%) 5936
No change  Duplicate Modules 589 589
Change  Duplicate Code 4.44%(-0.22%) 4.45%
No change  Packages 297 297
No change  Duplicate Packages 33 33
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#5642		      Baseline
#5633
Regression  JS 9.37MiB (+0.02%) 9.37MiB
No change  Other 144.26KiB 144.26KiB

Bundle analysis report Branch lilyfromseattle/author-website Project dashboard

Generated by RelativeCI Documentation Report issue

@lilyfromseattle lilyfromseattle changed the title WIP: feat(DIAM-97): Add field for link to author website feat(DIAM-97): Add field for link to author website Dec 16, 2025
@lilyfromseattle lilyfromseattle force-pushed the lilyfromseattle/author-website branch from 8d5c899 to a4760bf Compare December 17, 2025 20:04
@lilyfromseattle lilyfromseattle enabled auto-merge (squash) December 17, 2025 21:57
@lilyfromseattle lilyfromseattle merged commit 96eddca into main Dec 18, 2025
13 checks passed
@lilyfromseattle lilyfromseattle deleted the lilyfromseattle/author-website branch December 18, 2025 16:26
@artsy-peril artsy-peril bot mentioned this pull request Dec 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzucconi dzucconi dzucconi left review comments

Assignees

@lilyfromseattle lilyfromseattle

Labels

Jira Synced

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lilyfromseattle @dzucconi