This repository was archived by the owner on May 18, 2022. It is now read-only.
update-sailthru QoL improvements #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f metaphysics calls Co-authored-by: Luc Succes <[email protected]>
Contributor
Contributor
Author
|
hmm working on that test |
Contributor
|
@mdole are you still working on the test? |
Contributor
Author
|
Fixed in the most recent commit! I'm ooo this week; if it looks good to you
feel free to merge but if there's anything I should add I can do so when
I'm back :)
…On Tue, Feb 26, 2019, 4:29 PM Luc Succes ***@***.***> wrote:
@mdole <https://github.com/mdole> are you still working on the test?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#69 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFHQjnYaQ3R-QIKS70v5zFk4fW41deOmks5vRadTgaJpZM4bLJ3x>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
update-sailthruscript was halting on an error— @l2succes and I paired on finding the error, resolving, and making some other changes. Tweaks made:The error seems to be a result of URLs that have special characters in them, such as https://www.artsy.net/collection/salvador-dalí-venus
In case someone else needs to find and resolve errors with this script in the future, this command runs the script in debugging mode:
yarn nodemon --inspect-brk -r ts-node/register scripts/pushCollectionsToSailthru.tsYou might also need to change your METAPHYSICS_URL and MONGOHQ_URL env vars depending on where you plan to query.