Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 18, 2022. It is now read-only.

Conversation

@eessex
Copy link
Contributor

@eessex eessex commented Mar 14, 2019

These changes have not yet been applied to production (though they are active in staging now). This PR addresses all items flagged in https://artsyproduct.atlassian.net/browse/PLATFORM-1151, also tracked via https://artsyproduct.atlassian.net/browse/GROW-1156

  • Use kubectl version 1.10.7
  • Pin node runtime version and use Alpine build
  • Set up deploy user
  • Use Dumb-Init as ENTRYPOINT
  • Use npm rather than script to install yarn
  • Run yarn cache clean inline with yarn install
  • Update hokusai required version
  • Add mongo to hokusai dev build
  • Use autoscaling for replicas
  • Use ClusterFirst for dns
  • Update heath check endpoint delay/period/timeout seconds

@eessex
Copy link
Contributor Author

eessex commented Mar 14, 2019

These changes have been successfully applied to staging, I'll wait for any comments here before applying to production.

@peril-staging
Copy link
Contributor

peril-staging bot commented Mar 14, 2019

Warnings
⚠️ It looks like code was changed without adding anything to the Changelog.
You can add #trivial in the PR body to skip the check.

Generated by 🚫 dangerJS against 0db996d

@eessex
Copy link
Contributor Author

eessex commented Mar 14, 2019

Hokusai changes have been applied to production .

command: hokusai configure --kubectl-version 1.6.3 --s3-bucket artsy-citadel --s3-key k8s/config --platform linux
command:
hokusai configure --kubectl-version 1.10.7 --s3-bucket artsy-citadel
--s3-key k8s/config --platform linux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line-break intentional and valid, or auto-formatting gone wrong? There's a similar one below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this out and loaded it successfully so it seems valid.

@joeyAghion joeyAghion merged commit 611935b into artsy:master Mar 15, 2019
@eessex eessex mentioned this pull request Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants