This repository was archived by the owner on May 18, 2022. It is now read-only.
Automate pulling CSV using Google sheets API #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
New dependencies added: googleapisAuthor: Google Inc. Description: Google APIs Client Library for Node.js Homepage: https://github.com/googleapis/google-api-nodejs-client#readme
|
anandaroop
approved these changes
Apr 30, 2019
Member
anandaroop
left a comment
There was a problem hiding this comment.
Looks good to me!
I like how you've refactored the updating and sanitizing logic. This all looks well organized and tested. Thanks! 💯
| is_featured_artist_content: Boolean(is_featured_artist_content), | ||
| query: (artist_ids || gene_ids || tag_id || keyword) && { | ||
| artist_ids: artist_ids ? artist_ids.split(",").map(a => a.trim()) : [], | ||
| gene_ids: gene_ids ? gene_ids.split(",").map(a => a.trim()) : [], |
Member
There was a problem hiding this comment.
Do admins always strictly enter these as id1,id2, as opposed to id1, id2 (i.e. does this need to be more lenient and split on comma + whitespace?)
Contributor
Author
There was a problem hiding this comment.
that's what the .trim() method is for, it removes whitespace from both sides of the string after we split on ,.
Contributor
Author
|
Awesome! thanks @anandaroop |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://artsyproduct.atlassian.net/browse/GROW-1144
We make use of the Google Sheets API to get update KAWS. The goal is enable admins to update and ingest data without engineering intervention. This is only one part of enabling this, the google sheet script needs this endpoint to post the current googlesheet id the user wants to update.
In terms of security, this script uses a JWT which only has permissions to read a particular google sheet from artsy's google account.
hokusai dev startand our docker compose config