Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 18, 2022. It is now read-only.

Conversation

@xtina-starr
Copy link
Contributor

Addresses: GROW-1272

While working on Related Collections Footer Rail, I noticed that we don't yet have the ability to pass category as an argument to marketingCollections and filter by a specific category. This PR adds that capability.

@peril-staging
Copy link
Contributor

peril-staging bot commented May 23, 2019

Warnings
⚠️ It looks like code was changed without adding anything to the Changelog.
You can add #trivial in the PR body to skip the check.

Generated by 🚫 dangerJS against c2ed23f

Copy link
Contributor

@eessex eessex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@l2succes l2succes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


type Query {
collections(
category: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking an enum could make sense here but on second thought we don't know what categories are going to look like in the near future.

@l2succes l2succes merged commit 4d6c9f9 into master May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants