Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dalf
Copy link
Contributor

@dalf dalf commented Aug 9, 2019

  • limit is per aggregation instead of being global: it requires more memory and GC to remove old entries (see func (r *Rule) EraseOldAggregationValues(), unfinished there is no scheduled call to this function)
  • Aggregation: selector list are combined with an AND instead of an OR (see func (r *Rule) Match(ctx *fasthttp.RequestCtx) bool)

limit is per aggregation instead of being global: it requires more memory and GC to remove old entries.
Aggregation: selector list are combined with an AND instead of an OR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant