This repository was archived by the owner on Feb 16, 2020. It is now read-only.
Fixed getFee() for binance exchange #2578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@askmike BTW why gekko does not use? https://www.npmjs.com/package/ccxt this library looks like implements interface to all exchanges |
askmike
approved these changes
Oct 20, 2018
Owner
|
nice catch, thanks! |
Owner
It's a huge library and doesn't play nice with Gekko Broker (Gekko's internal order execution library). |
askmike
pushed a commit
that referenced
this pull request
Oct 23, 2018
* * fixed getFee() for binance
This was referenced Oct 25, 2018
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
binance.getFee() - 0.1
bitfinex.getFee() - 0.002
What is the new behavior (if this is a feature change)?
binance.getFee() - 0.001
bitfinex.getFee() - 0.002
Other information:
Here is binance raw response. As you can see binance gives us fee as 10, when I would expect 0.1
{ makerCommission: 10,
takerCommission: 10,
buyerCommission: 0,
sellerCommission: 0,
canTrade: true,
canWithdraw: true,
canDeposit: true,
So we need to divide by 10000 to get decimal fee for binance