Improve selection of atomic validation attribute, including resource-level option #2356
Conversation
| |> Ash.create!() | ||
|
|
||
| # Validation passes for recent books, fails for older ones. | ||
| assert {:ok, %Book{year: 2020}} = Book.validation_without_update(recent_book) |
There was a problem hiding this comment.
We need to validate that this does not prevent the underlying change to this attribute. Shouldn't this be 2021?
There was a problem hiding this comment.
There are two actions on Book, one of them does the atomic_update to increment to 2021 and the other (this one) doesn't.
As soon as you have another atomic attribute in the changeset, it gets chosen as the validation attribute, so the only way to exercise the default target attribute is not having any existing atomic attributes there.
Want me to add a separate test just validating that we can still update :title?
There was a problem hiding this comment.
That would be great yes, but probably other tests would have failed in retrospect. Can't hurt IMO
There was a problem hiding this comment.
Sure, just pushed another commit with the extra test
|
🚀 Thank you for your contribution! 🚀 |
|
@stevebrambilla just a note for you in case it matters, this logic has been slightly modified to actually choose the last changing attribute in the atomics list, not the first. |
The way atomic validations currently work is that it picks the first primary key field and uses that for the validation expression, assigning the current value to itself if the condition passes.
In our case, the selected primary key field is also the distribution column used for Citus, so we get this error:
This PR makes two changes around this:
atomic_validation_default_target_attributeto:resourceso resources can specify a compatible attribute.The atomic validation attribute now take the first of:
atomic_validation_default_target_attributeContributor checklist
Leave anything that you believe does not apply unchecked.