Update docker.yml to include latest tag#1818
Merged
J535D165 merged 1 commit intoasreview:mainfrom Sep 2, 2024
Merged
Conversation
Member
|
Thanks. The use of the latest tag is widely discussed and considered to be a bad practice. That's why I removed it before, but I'm happy to introduce it again. |
Member
Author
|
@J535D165 I agree its bad practice for the sake of reproducibility (can't verify a version if latest is used, pipelines will break if latest is used, etc). But many MANY users take this standard and I think facilitating this is more important in this case. |
Member
|
https://github.com/asreview/asreview/pkgs/container/asreview new version with latest tag can be found in the registry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1815 is correct, there's no latest package. Maybe we should also add this to the 1.6 tag branch.