Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Fix ecosystem check for indico#10164

Merged
MichaReiser merged 1 commit intomainfrom
fix-ecosystem-check
Feb 29, 2024
Merged

Fix ecosystem check for indico#10164
MichaReiser merged 1 commit intomainfrom
fix-ecosystem-check

Conversation

@MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Feb 29, 2024 •
edited
Loading

Summary

Remove the S410 rule from the indico ecosystem check

@MichaReiser MichaReiser added the ci Related to internal CI tooling label Feb 29, 2024
@MichaReiser MichaReiser force-pushed the fix-ecosystem-check branch 2 times, most recently from 8a14243 to 78ff9f0 Compare February 29, 2024 08:50
@MichaReiser MichaReiser marked this pull request as ready for review February 29, 2024 09:01
MichaReiser
MichaReiser commented Feb 29, 2024
View reviewed changes
python/ruff-ecosystem/ruff_ecosystem/defaults.py
# Remove once indico removed S401 from their ignore configuration
config_overrides={
"lint.ignore": [
"E226", # allow omitting whitespace around arithmetic operators
Copy link
Member Author

@MichaReiser MichaReiser Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit silly but I couldn't find a way to remove a single rule from ignore

@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error) 

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error) 

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

@MichaReiser MichaReiser merged commit 72ccb34 into main Feb 29, 2024
@MichaReiser MichaReiser deleted the fix-ecosystem-check branch February 29, 2024 09:27
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
@MichaReiser @nkxxll
Fix ecosystem check for indico (astral-sh#10164)
4f4c9f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci Related to internal CI tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MichaReiser